48 lines
1.8 KiB
Diff
48 lines
1.8 KiB
Diff
From 196da3f3f76a46905f7daab29c56974f1aba9a7a Mon Sep 17 00:00:00 2001
|
||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||
Date: Fri, 5 Jan 2024 19:40:06 +0200
|
||
Subject: [PATCH] drm/rockchip: vop2: Drop unused if_dclk_rate variable
|
||
MIME-Version: 1.0
|
||
Content-Type: text/plain; charset=UTF-8
|
||
Content-Transfer-Encoding: 8bit
|
||
|
||
Commit 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
|
||
introduced a variable which ended up being unused:
|
||
|
||
rockchip_drm_vop2.c:1688:23: warning: variable ‘if_dclk_rate’ set but not used [-Wunused-but-set-variable]
|
||
|
||
This has been initially used as part of a formula to compute the clock
|
||
dividers, but eventually it has been replaced by static values.
|
||
|
||
Drop the variable declaration and move its assignment to the comment
|
||
block, to serve as documentation of how the constants have been
|
||
generated.
|
||
|
||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
|
||
Link: https://patchwork.freedesktop.org/patch/msgid/20240105174007.98054-1-cristian.ciocaltea@collabora.com
|
||
---
|
||
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 +--
|
||
1 file changed, 1 insertion(+), 2 deletions(-)
|
||
|
||
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
|
||
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
|
||
@@ -1691,7 +1691,6 @@ static unsigned long rk3588_calc_cru_cfg
|
||
unsigned long dclk_core_rate = v_pixclk >> 2;
|
||
unsigned long dclk_rate = v_pixclk;
|
||
unsigned long dclk_out_rate;
|
||
- unsigned long if_dclk_rate;
|
||
unsigned long if_pixclk_rate;
|
||
int K = 1;
|
||
|
||
@@ -1706,8 +1705,8 @@ static unsigned long rk3588_calc_cru_cfg
|
||
}
|
||
|
||
if_pixclk_rate = (dclk_core_rate << 1) / K;
|
||
- if_dclk_rate = dclk_core_rate / K;
|
||
/*
|
||
+ * if_dclk_rate = dclk_core_rate / K;
|
||
* *if_pixclk_div = dclk_rate / if_pixclk_rate;
|
||
* *if_dclk_div = dclk_rate / if_dclk_rate;
|
||
*/
|