Nanako/openwrt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ath79: ag71xx: fix error handling for of_get_phy_mode

Browse Source 
Errors are not indicated by the phy_mode value but returned separately
from the function.

Signed-off-by: David Bauer <mail@david-bauer.net>
This commit is contained in:
David Bauer 2021-05-03 00:27:59 +02:00
parent 204956aea5
commit a273ac4d61
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
View File

@ -1677,12 +1677,12 @@ static int ag71xx_probe(struct platform_device *pdev)
} }
#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,10,0) #if LINUX_VERSION_CODE >= KERNEL_VERSION(5,10,0)
of_get_phy_mode(np, &ag->phy_if_mode); err = of_get_phy_mode(np, &ag->phy_if_mode);
if (err < 0) {
#else #else
ag->phy_if_mode = of_get_phy_mode(np); ag->phy_if_mode = of_get_phy_mode(np);
#endif
if (ag->phy_if_mode < 0) { if (ag->phy_if_mode < 0) {
#endif
dev_err(&pdev->dev, "missing phy-mode property in DT\n"); dev_err(&pdev->dev, "missing phy-mode property in DT\n");
return ag->phy_if_mode; return ag->phy_if_mode;
} }